grpc-web: remove envoy.reloadable_features.grpc_web_fix_non_proto_encoded_response_handling#18620
Merged
lizan merged 3 commits intoenvoyproxy:mainfrom Nov 1, 2021
dio:fix-18436
Merged
grpc-web: remove envoy.reloadable_features.grpc_web_fix_non_proto_encoded_response_handling#18620lizan merged 3 commits intoenvoyproxy:mainfrom dio:fix-18436
lizan merged 3 commits intoenvoyproxy:mainfrom
dio:fix-18436
Conversation
…oded_response_handling This patch removes envoy.reloadable_features.grpc_web_fix_non_proto_encoded_response_handling and relevant legacy code paths. Fixes #18436 Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
|
@dio can you resolve conflicts? |
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
lizan
approved these changes
Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: This patch removes
envoy.reloadable_features.grpc_web_fix_non_proto_encoded_response_handling
and relevant legacy code paths.
Risk Level: Low
Testing: Updated
Docs Changes: N/A
Release Notes: Added
Platform-Specific Features: N/A
Fixes #18436
Signed-off-by: Dhi Aurrahman dio@rockybars.com